Commit
b5125b1099cf5cf12beb0520d5896b9a1d7850ae
was broken.
We didn't add empty .ALL hierarchies as needed;
we added empty (non-existant) hierarchies without
appended '.ALL', and didn't add the original
empty group we started with.
(What's more, gatherstats didn't even start any
more due to missing ex- and import of
&ParseHierarchies from NewsStats.pm.)
Fixes #52 (and some more breakage).
Signed-off-by: Thomas Hochstein <thh@inter.net>
SplitPeriod
ListMonth
ListNewsgroups
SplitPeriod
ListMonth
ListNewsgroups
ReadGroupList
OutputData
FormatOutput
ReadGroupList
OutputData
FormatOutput
-use NewsStats qw(:DEFAULT :TimePeriods ListNewsgroups ReadGroupList);
+use NewsStats qw(:DEFAULT :TimePeriods ListNewsgroups ParseHierarchies ReadGroupList);
use DBI;
use Getopt::Long qw(GetOptions);
use DBI;
use Getopt::Long qw(GetOptions);
if (%ValidGroups) {
foreach (sort keys %ValidGroups) {
if (!defined($Postings{$_})) {
if (%ValidGroups) {
foreach (sort keys %ValidGroups) {
if (!defined($Postings{$_})) {
- # expand newsgroup with hierarchies
- my @Newsgroups = ParseHierarchies($_);
- # add each empty newsgroup and empty hierarchies, too, as needed
- foreach (@Newsgroups) {
- if (!defined($Postings{$_})) {
- $Postings{$_} = 0;
- warn (sprintf("ADDED: %s as empty group\n",$_));
+ # add current newsgroup as empty group
+ $Postings{$_} = 0;
+ warn (sprintf("ADDED: %s as empty group\n",$_));
+ # add empty hierarchies for current newsgroup as needed
+ foreach (ParseHierarchies($_)) {
+ my $Hierarchy = $_ . '.ALL';
+ if (!defined($Postings{$Hierarchy})) {
+ $Postings{$Hierarchy} = 0;
+ warn (sprintf("ADDED: %s as empty group\n",$Hierarchy));