From: Thomas Hochstein <thh@thh.name>
Date: Tue, 29 Mar 2022 20:56:47 +0000 (+0200)
Subject: Non-greedy matching for votestrings.
X-Git-Url: https://code.th-h.de/?p=usenet%2Fusevote.git;a=commitdiff_plain;h=a7ea02d5923c106e8a1e597d399262ed615a1704

Non-greedy matching for votestrings.

A single choice on a ballot has this format:

 #1   [            ]  This or that

The regexp in uvvote.pl's process_vote() will
match and extract what's beetwen "[" and "]".
But if "This or that" contains a "]", the
match will be too greedy:

 #1   [            ]  This [or that]
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ <- match

Fix that by using a non-greedy operator.

Signed-off-by: Thomas Hochstein <thh@thh.name>
---

diff --git a/uvvote.pl b/uvvote.pl
index c101f1f..a151250 100755
--- a/uvvote.pl
+++ b/uvvote.pl
@@ -271,7 +271,7 @@ sub process_vote {
     }
 
     # this matches on a single appearance:
-    if ($$body =~ /#$votenum\W*?\[(.+)\]/) {
+    if ($$body =~ /#$votenum\W*?\[(.+?)\]/) {
       # one or more vote strings were found
       $onevote ||= 1; # set $onevote to 1 if it was 0
       my $votestring = $1;